Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix exception on start up about device lists #15041

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix exception on start up about device lists #15041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cae7d
Fix exception on start up about device lists
erikjohnston Feb 9, 2023
81b77be
Newsfile
erikjohnston Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15041.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a rare exception in logs on start up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check---if this error occurs on startup, will it go away once new device list changes arrive in the stream?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so

1 change: 1 addition & 0 deletions synapse/storage/databases/main/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def __init__(
("device_lists_outbound_pokes", "stream_id"),
("device_lists_changes_in_room", "stream_id"),
("device_lists_remote_pending", "stream_id"),
("device_lists_changes_converted_stream_position", "stream_id"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a blocking comment.)

Cross-ref, #14914 -- I really wonder if there's something systematic missing here. 😢

],
is_writer=hs.config.worker.worker_app is None,
)
Expand Down