Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

When populating the user directory, query remote servers for user profiles instead of leaking the profiles in private rooms. [rei:userdirpriv] #15091

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Feb 17, 2023

Fixes: #5677

Follows: #14756

Base: rei/userdirpriv2_refresh_remotes

This pull request is commit-by-commit review friendly.

Original commit schedule, with full messages:

  1. Rename method to make obvious it only applies to local users

  2. Add another temporary table to the user directory background update for storing remote users needing lookup

  3. Don't add private remote users straight to the user directory
    Instead, queue them up to be added to the stale profile queue.

  4. Add a background update stage to sort the remote users into the stale profile queue as appropriate

  5. (ugly?) Kick off the fetching of remote profiles once ready

  6. When we start populating the user directory, clear out the old tables first if they're there

  7. When rebuilding user dir, schedule the new task

  8. Schedule a user directory rebuild

Stacked PR Chain: rei:userdirpriv

PR Title Status Merges Into
#14755 Preparatory work to fix the user directory assuming that any remote membership state events represent a profile change. -
#14756 Refresh remote profiles that have been marked as stale, in order to fill the user directory. #14755
#15091 👉 (Draft) When populating the user directory, query remote servers for user profiles instead of leaking the profiles in private rooms. #14756

@reivilibre reivilibre force-pushed the rei/userdirpriv3_queue_to_refresh_initialpop branch from e812a47 to d4df71d Compare March 16, 2023 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant