Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Experimental Unix socket support #15353

Merged
merged 20 commits into from
Apr 3, 2023

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    906acaf View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Create listen_unix().

    Two options, 'path' to the file and 'mode' of permissions(not umask, recommend 666 as default as
    nginx/other reverse proxies write to it and it's setup as user www-data)
    
    For the moment, leave the option to always create a PID lockfile turned on by default
    realtyem committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    aac7fac View commit details
    Browse the repository at this point in the history
  2. Create UnixListenerConfig and wire it up.

    Rename ListenerConfig to TCPListenerConfig, then Union them together into ListenerConfig.
    This spidered around a bit, but I think I got it all. Metrics and manhole have been placed
    behind a conditional in case of accidental putting them onto a unix socket.
    
    Use new helpers to get if a listener is configured for TLS, and to help create a site tag
    for logging.
    
    There are 2 TODO things in parse_listener_def() to finish up at a later point.
    realtyem committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    9abd099 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Refactor SynapseRequest to handle logging correctly when using a unix…

    … socket.
    
    This prevents an exception when an IP address can not be retrieved for a request.
    realtyem committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    43a6ee9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b93a29 View commit details
    Browse the repository at this point in the history
  3. No silent failures on generic workers when trying to use a unix socke…

    …t with metrics or manhole.
    realtyem committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    3267581 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1e0452f View commit details
    Browse the repository at this point in the history
  5. Update docstring for listen_unix() to remove reference to a hardcoded…

    … permission of 0o666 and add a few comments saying where the default IS declared.
    realtyem committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c0eb5b3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9fdbb5d View commit details
    Browse the repository at this point in the history
  7. Linting

    realtyem committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    67eecf0 View commit details
    Browse the repository at this point in the history
  8. Changelog

    realtyem committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c74ad1d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2309543 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Configuration menu
    Copy the full SHA
    3703cd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8876780 View commit details
    Browse the repository at this point in the history
  3. review: roll conditional for http_options.tag into get_site_tag() hel…

    …per(and add docstring)
    realtyem committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    d6b88f3 View commit details
    Browse the repository at this point in the history
  4. review: enhance the conditionals for checking if a port or path is va…

    …lid, remove a TODO line
    realtyem committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    2acf0a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. review: Try updating comment in get_client_ip_if_available to clarify…

    … what is being retrieved and why
    realtyem committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2a99e49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    547ff5f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. review: In parse_listener_def(), raise ConfigError if neither socket_…

    …path nor port is declared(and fix a typo)
    realtyem committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    d1742a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cfdc5ac View commit details
    Browse the repository at this point in the history