This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix missing dependencies in background jobs #15724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end on `replace_stream_ordering_column` job
…his job depend on the `add_stream_ordering` bg job
…on `add_event_stream_ordering` bg job
…l always fail that
H-Shay
force-pushed
the
shay/fix_dependency
branch
from
62348e3
to
9cd13d0
Compare
|
Closed in favor of #15887 as this did not work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves two foreground schema migrations to background jobs in order to express dependencies amongst them. Prior to this, if Synapse was upgraded from a sufficiently old version the foreground migrations would apply before a background job also touching the same column was finished, resulting in the background job failing. Fixes #15677. Best reviewed commit by commit.