This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix TLS in the federation outbound proxy #15886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added
A-Federation
Z-Time-Tracked
6 tasks
MadLittleMods
commented
Jul 6, 2023
| @@ -0,0 +1 @@ | |||
| Allow configuring the set of workers to proxy outbound federation traffic through via `outbound_federation_restricted_to`. | |||
There was a problem hiding this comment.
Same changelog as #15773 so they merge since we're fixing something that was just merged.
7 tasks
MadLittleMods
commented
Jul 10, 2023
| @@ -0,0 +1 @@ | |||
| Allow configuring the set of workers to proxy outbound federation traffic through via `outbound_federation_restricted_to`. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TLS in the federation outbound proxy
Same fix as #15746
Thanks to @realtyem for pointing it out!
creatorForNetloc(...)doesn't come with typing and expectshostto bebytesinstead of astr. It would be nice to add typing somehow so we don't keep running into this foot-gunProxyAgentwas introduced with the federation outbound proxy: #15773(this is wholly untested)
Pull Request Checklist
Pull request includes a sign off(run the linters)