This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add a user directory #2252
Merged
Merged
Add a user directory #2252
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
eeb2f9e
Add user_directory to database
erikjohnston 42137ef
Don't go round in circles
erikjohnston 3e123b8
Start later
erikjohnston 1685245
Add call later
erikjohnston b5db4ed
Update room column when room becomes unpublic
erikjohnston 3b5f22c
Add search
erikjohnston 45a5df5
Add REST API
erikjohnston 535c99f
Use POST
erikjohnston 293ef29
Weight differently
erikjohnston 63fda37
Add comments
erikjohnston 350622a
Handle the server leaving a public room
erikjohnston dc51af3
Pull max id from correct table
erikjohnston 5d79d72
Split out directory and search tables
erikjohnston 304880d
Add stream change cache
erikjohnston 63c58c2
Limit number of things we fetch out of the db
erikjohnston 4abcff0
Fix typo
erikjohnston f091061
Fix tests
erikjohnston f979149
Typos
erikjohnston b2d8d07
Lifts things into separate function
erikjohnston f1378ae
Convert to int
erikjohnston cc7609a
Comment briefly on how we keep user_directory up to date
erikjohnston 5dd1b2c
Use unique indices
erikjohnston f5cc22b
Comment on why arbitrary comments
erikjohnston a757dd4
Use prefix matching
erikjohnston 036362e
Order by if they have profile info
erikjohnston 0fe6f3c
Bug fixes and logging
erikjohnston 9c7db24
Fix removing users
erikjohnston 59dbb47
Remove spurious inlineCallbacks
erikjohnston 8be6fd9
Check if host is still in room
erikjohnston 7233341
Comments
erikjohnston 02a6108
Tweak search query
erikjohnston d5477c7
Tweak search query
erikjohnston 21e255a
Split the table in two
erikjohnston 4d039aa
Fix sqlite
erikjohnston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
# -*- coding: utf-8 -*- | ||
# Copyright 2017 Vector Creations Ltd | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import logging | ||
|
||
from twisted.internet import defer | ||
|
||
from synapse.api.errors import SynapseError | ||
from synapse.http.servlet import RestServlet, parse_json_object_from_request | ||
from ._base import client_v2_patterns | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class UserDirectorySearchRestServlet(RestServlet): | ||
PATTERNS = client_v2_patterns("/user_directory/search$") | ||
|
||
def __init__(self, hs): | ||
""" | ||
Args: | ||
hs (synapse.server.HomeServer): server | ||
""" | ||
super(UserDirectorySearchRestServlet, self).__init__() | ||
self.hs = hs | ||
self.auth = hs.get_auth() | ||
self.user_directory_handler = hs.get_user_directory_handler() | ||
|
||
@defer.inlineCallbacks | ||
def on_POST(self, request): | ||
"""Searches for users in directory | ||
|
||
Returns: | ||
dict of the form:: | ||
|
||
{ | ||
"limited": <bool>, # whether there were more results or not | ||
"results": [ # Ordered by best match first | ||
{ | ||
"user_id": <user_id>, | ||
"display_name": <display_name>, | ||
"avatar_url": <avatar_url> | ||
} | ||
] | ||
} | ||
""" | ||
yield self.auth.get_user_by_req(request, allow_guest=False) | ||
body = parse_json_object_from_request(request) | ||
|
||
limit = body.get("limit", 10) | ||
limit = min(limit, 50) | ||
|
||
try: | ||
search_term = body["search_term"] | ||
except: | ||
raise SynapseError(400, "`search_term` is required field") | ||
|
||
results = yield self.user_directory_handler.search_users(search_term, limit) | ||
|
||
defer.returnValue((200, results)) | ||
|
||
|
||
def register_servlets(hs, http_server): | ||
UserDirectorySearchRestServlet(hs).register(http_server) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
# Copyright 2017 Vector Creations Ltd | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import logging | ||
|
||
from synapse.storage.prepare_database import get_statements | ||
from synapse.storage.engines import PostgresEngine, Sqlite3Engine | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
BOTH_TABLES = """ | ||
CREATE TABLE user_directory_stream_pos ( | ||
Lock CHAR(1) NOT NULL DEFAULT 'X' UNIQUE, -- Makes sure this table only has one row. | ||
stream_id BIGINT, | ||
CHECK (Lock='X') | ||
); | ||
|
||
INSERT INTO user_directory_stream_pos (stream_id) VALUES (null); | ||
|
||
CREATE TABLE user_directory ( | ||
user_id TEXT NOT NULL, | ||
room_id TEXT NOT NULL, -- A room_id that we know the user is joined to | ||
display_name TEXT, | ||
avatar_url TEXT | ||
); | ||
|
||
CREATE INDEX user_directory_room_idx ON user_directory(room_id); | ||
CREATE UNIQUE INDEX user_directory_user_idx ON user_directory(user_id); | ||
|
||
CREATE TABLE users_in_pubic_room ( | ||
user_id TEXT NOT NULL, | ||
room_id TEXT NOT NULL -- A room_id that we know is public | ||
); | ||
|
||
CREATE INDEX users_in_pubic_room_room_idx ON users_in_pubic_room(room_id); | ||
CREATE UNIQUE INDEX users_in_pubic_room_user_idx ON users_in_pubic_room(user_id); | ||
""" | ||
|
||
|
||
POSTGRES_TABLE = """ | ||
CREATE TABLE user_directory_search ( | ||
user_id TEXT NOT NULL, | ||
vector tsvector | ||
); | ||
|
||
CREATE INDEX user_directory_search_fts_idx ON user_directory_search USING gin(vector); | ||
CREATE UNIQUE INDEX user_directory_search_user_idx ON user_directory_search(user_id); | ||
""" | ||
|
||
|
||
SQLITE_TABLE = """ | ||
CREATE VIRTUAL TABLE user_directory_search | ||
USING fts4 ( user_id, value ); | ||
""" | ||
|
||
|
||
def run_create(cur, database_engine, *args, **kwargs): | ||
for statement in get_statements(BOTH_TABLES.splitlines()): | ||
cur.execute(statement) | ||
|
||
if isinstance(database_engine, PostgresEngine): | ||
for statement in get_statements(POSTGRES_TABLE.splitlines()): | ||
cur.execute(statement) | ||
elif isinstance(database_engine, Sqlite3Engine): | ||
for statement in get_statements(SQLITE_TABLE.splitlines()): | ||
cur.execute(statement) | ||
else: | ||
raise Exception("Unrecognized database engine") | ||
|
||
|
||
def run_upgrade(*args, **kwargs): | ||
pass |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a UNIQUE index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not on room_id, no.
But I've added one to user_id.