This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Send down device list change notif when member leaves/rejoins room #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Sep 8, 2017
synapse/handlers/sync.py
Outdated
|
|
||
| defer.returnValue((newly_joined_rooms, newly_joined_users)) | ||
| newly_left_users -= newly_joined_users |
There was a problem hiding this comment.
this looks dodge. What happens if the user joined and then left? they appear in newly_joined and not newly_left?
There was a problem hiding this comment.
oh right, we're merging the results across rooms. I think it's ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.