This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Better handling of odd PLs during room upgrades #4099
Merged
Merged
Commits on Oct 25, 2018
-
Factor _generate_room_id out of create_room
we're going to need this for room upgrades.
1Configuration menu - View commit details
-
Copy full SHA for 871c4ab - Browse repository at this point
Copy the full SHA 871c4abView commit details -
Make room_member_handler a member of RoomCreationHandler
... to save passing it into `_send_events_for_new_room`
1Configuration menu - View commit details
-
Copy full SHA for 7f7b2cd - Browse repository at this point
Copy the full SHA 7f7b2cdView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e194817 - Browse repository at this point
Copy the full SHA e194817View commit details -
Basic initial support for room upgrades
Currently just creates a new, empty, room, and sends a tombstone in the old room.
1Configuration menu - View commit details
-
Copy full SHA for 0f7d1c9 - Browse repository at this point
Copy the full SHA 0f7d1c9View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 4cda300 - Browse repository at this point
Copy the full SHA 4cda300View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 1b9f253 - Browse repository at this point
Copy the full SHA 1b9f253View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 3a263bf - Browse repository at this point
Copy the full SHA 3a263bfView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e6babc2 - Browse repository at this point
Copy the full SHA e6babc2View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 68c0ce6 - Browse repository at this point
Copy the full SHA 68c0ce6View commit details -
This test stubbed out some stuff in a very weird way. I have no idea why. It broke.
1Configuration menu - View commit details
-
Copy full SHA for 474810d - Browse repository at this point
Copy the full SHA 474810dView commit details
Commits on Oct 26, 2018
-
Improve comments, get old room state from the context we already have
Configuration menu - View commit details
-
Copy full SHA for 193cadc - Browse repository at this point
Copy the full SHA 193cadcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54bbe71 - Browse repository at this point
Copy the full SHA 54bbe71View commit details -
Better handling of odd PLs during room upgrades
Fixes handling of rooms where we have permission to send the tombstone, but not other state. We need to (a) fail more gracefully when we can't send the PLs in the old room, and (b) not set the PLs in the new room until we are done with the other stuff.
Configuration menu - View commit details
-
Copy full SHA for db24d7f - Browse repository at this point
Copy the full SHA db24d7fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.