Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove usages of event ID's domain #4514

Merged
merged 9 commits into from
Jan 29, 2019
Merged

Remove usages of event ID's domain #4514

merged 9 commits into from
Jan 29, 2019

Commits on Jan 29, 2019

  1. Only check event IDs domain signed event for V1 and V2 

    Since newer versions of events don't have the same format for event ID.
    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    770b823 View commit details
    Browse the repository at this point in the history

  2. Remove event ID usage when checking if new room 

    The event ID is changing, so we can no longer get the domain from it. On
the other hand, the check is unnecessary.
    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b1fffca View commit details
    Browse the repository at this point in the history

  3. Use snder and not event ID domain to check if ours 

    The transaction queue only sends out events that we generate. This was
done by checking domain of event ID, but that can no longer be used.
Instead, we may as well use the sender field.
    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    55d9024 View commit details
    Browse the repository at this point in the history

  4. Use event origin for filtering incoming events 

    We only process events sent to us from a server if the event ID matches
the server, to help guard against federation storms. We replace this
with a check against the event origin.
    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    8e3d34e View commit details
    Browse the repository at this point in the history

  5. Only check event ID domain for signatures for V1 events 

    In future version events won't have an event ID, so we won't be able to
do this check.
    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    840068b View commit details
    Browse the repository at this point in the history

  6. Don't assert an event must have an event ID

    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    610f083 View commit details
    Browse the repository at this point in the history

  7. Newsfile

    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b40abe0 View commit details
    Browse the repository at this point in the history

  8. check event format version not room version

    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    655ce03 View commit details
    Browse the repository at this point in the history

  9. Update comment

    @erikjohnston
    erikjohnston committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ff2f65d View commit details
    Browse the repository at this point in the history