This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add configurable room list publishing rules #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying who and what is allowed to be published onto the public room list
Codecov Report
@@ Coverage Diff @@
## develop #4647 +/- ##
===========================================
+ Coverage 75.27% 75.27% +<.01%
===========================================
Files 338 338
Lines 34579 34620 +41
Branches 5655 5669 +14
===========================================
+ Hits 26030 26061 +31
- Misses 6959 6965 +6
- Partials 1590 1594 +4 |
richvdh
suggested changes
Feb 14, 2019
|
Hopefully the comments make more sense now? |
|
And err, woops, about how to handle multiple aliases. I think the behaviour makes the most sense. |
richvdh
reviewed
Feb 14, 2019
| # `alias_creation_rules`. | ||
| # | ||
| # If the room has one or more aliases associated with it, only one of | ||
| # the aliases needs to match the alias rule. If there are no aliases |
There was a problem hiding this comment.
what does it even mean to publish a room in the room directory when it doesn't have an alias, ooi?
There was a problem hiding this comment.
It's a perfectly legit thing to do, while remote users wouldn't be able to join the room local users still would happily be able to.
Though I have a suspicion we might require an alias before we actually publish the room
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying who and what is allowed to be published onto the
public room list.