Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add rate-limiting on registration #4735

Merged
merged 26 commits into from
Mar 5, 2019
Merged

Add rate-limiting on registration #4735

merged 26 commits into from
Mar 5, 2019

Conversation

babolivier
Copy link
Contributor

Default values for the config parameters are placeholders. I used these because they're the default values for the matching message sending parameters, but unsure of how relevant that is to auth requests.

@babolivier babolivier requested a review from a team February 25, 2019 14:51
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments that are mostly just a bit of tidying up

synapse/api/ratelimiting.py Outdated Show resolved Hide resolved
synapse/api/ratelimiting.py Outdated Show resolved Hide resolved
tests/rest/client/v2_alpha/test_register.py Outdated Show resolved Hide resolved
synapse/handlers/register.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #4735 into develop will increase coverage by <.01%.
The diff coverage is 88.23%.

@@             Coverage Diff             @@
##           develop    #4735      +/-   ##
===========================================
+ Coverage    75.15%   75.15%   +<.01%     
===========================================
  Files          340      340              
  Lines        34925    34942      +17     
  Branches      5727     5730       +3     
===========================================
+ Hits         26247    26262      +15     
- Misses        7060     7063       +3     
+ Partials      1618     1617       -1

tests/rest/client/v2_alpha/test_register.py Outdated Show resolved Hide resolved
@babolivier babolivier requested a review from a team March 4, 2019 10:26
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

synapse/replication/http/register.py Outdated Show resolved Hide resolved
tests/rest/client/v2_alpha/test_register.py Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants