This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
previously requested changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments that are mostly just a bit of tidying up
Co-Authored-By: babolivier <[email protected]>
…into babolivier/ratelimit
Codecov Report
@@ Coverage Diff @@
## develop #4735 +/- ##
===========================================
+ Coverage 75.15% 75.15% +<.01%
===========================================
Files 340 340
Lines 34925 34942 +17
Branches 5727 5730 +3
===========================================
+ Hits 26247 26262 +15
- Misses 7060 7063 +3
+ Partials 1618 1617 -1 |
hawkowl
previously requested changes
Feb 25, 2019
erikjohnston
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values for the config parameters are placeholders. I used these because they're the default values for the matching message sending parameters, but unsure of how relevant that is to auth requests.