This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update Apache Setup To Remove Location Syntax #4870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove location syntax
Remove location syntax.
please could you add a quick note to the changelog directory so that the CI passes? |
Should be set now. 😁 |
Codecov Report
@@ Coverage Diff @@
## develop #4870 +/- ##
============================================
+ Coverage 59.57% 71.95% +12.38%
============================================
Files 326 304 -22
Lines 33921 33148 -773
Branches 5597 5510 -87
============================================
+ Hits 20209 23853 +3644
+ Misses 12298 7620 -4678
- Partials 1414 1675 +261 |
Codecov Report
@@ Coverage Diff @@
## develop #4870 +/- ##
============================================
+ Coverage 59.57% 77.24% +17.66%
============================================
Files 326 326
Lines 33921 35259 +1338
Branches 5597 6023 +426
============================================
+ Hits 20209 27235 +7026
+ Misses 12298 6318 -5980
- Partials 1414 1706 +292 |
richvdh
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
anoadragon453
added a commit
that referenced
this pull request
Mar 26, 2019
* develop: (141 commits) Make federation endpoints more tolerant of trailing slashes v2 (#4935) Fix ClientReplicationStreamProtocol.__str__ (#4929) Fix bug where read-receipts lost their timestamps (#4927) Use an explicit dbname for postgres connections in the tests. (#4928) Fix nginx example in ACME doc. (#4923) Refactor out state delta handling into its own class (#4917) Newsfile Use yaml safe_load Allow newsfragments to end with exclamation marks! (#4912) Some more porting to HomeserverTestCase and remove old RESTHelper (#4913) Clean up backoff_on_404 and metehod calls Update changelog.d/4908.bugfix Update Apache Setup To Remove Location Syntax (#4870) isort Newsfile Fix typo and add description Deny peeking into rooms that have been blocked Rejig testcase to make it more extensible Remove debug Add tests ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This one should close #4841. Many thanks to @dev4223 for bringing it up and finding a solution.
Signed-off-by: Colin White