This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Rewrite Datastore.get_server_verify_keys #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in collecting a merged dict of keys: it is sufficient to consider just the new keys which have been fetched by the most recent key_fetch_fns.
richvdh
force-pushed
the
rav/rewrite_g_s_v_k
branch
from
f22c8d7
to
739fb5c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5030 +/- ##
===========================================
- Coverage 61.59% 61.58% -0.02%
===========================================
Files 332 332
Lines 34215 34216 +1
Branches 5643 5643
===========================================
- Hits 21076 21073 -3
- Misses 11625 11629 +4
Partials 1514 1514 |
since we're pulling everything out of KeyStore anyway, we may as well simplify it.
Rewrite this so that it doesn't hammer the database.
richvdh
force-pushed
the
rav/rewrite_g_s_v_k
branch
from
1d6f9e5
to
1f1e8dd
Compare
erikjohnston
approved these changes
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite this so that it doesn't hammer the database.