This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Blacklist 0.0.0.0 and :: by default for URL previews #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
approved these changes
May 3, 2019
| @@ -274,6 +279,9 @@ def default_config(self, data_dir_path, **kwargs): | |||
| # synapse to issue arbitrary GET requests to your internal services, | |||
| # causing serious security issues. | |||
| # | |||
| # This must be specified if url_preview_enabled. It is recommended that you | |||
| # uncomment the following list as a starting point. | |||
| # | |||
There was a problem hiding this comment.
Wouldn't it be sensible to add something like "0.0.0.0 and :: are always blacklisted" somewhere around here?
turt2live
added a commit
to t2bot/matrix-media-repo
that referenced
this pull request
May 4, 2019
This was referenced May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.