This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Rewrite presence for performance. #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for entry in self.entries: | ||
| # Add to first bucket we find. This should gracefully handle inserts | ||
| # for times in the past. | ||
| if entry.end_key >= then_key: |
There was a problem hiding this comment.
If there are no "gaps" in the in the entries list, then why do we need to scan to find the appropriate entry?
Could we simply index into the entry list instead?
| ) | ||
|
|
||
| if not allowed: | ||
| raise AuthError(403, "You are allowed to see their presence.") |
|
LGTM |
erikjohnston
force-pushed
the
erikj/presence
branch
from
62710c4
to
e12ec33
Compare
erikjohnston
added a commit
that referenced
this pull request
Feb 19, 2016
Rewrite presence for performance.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m.presencelast_active_agotime remains below 1 minute, don't send updates to client. This is done by including acurrently_activeboolean field that when true indicates that clients should assume the user is only and active until further notice (i.e., their "last active" should be "now"). Clients will receive a new presence event when users stop being active.TODO: