This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
MSC2326: Add background update to take previous events into account #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
previously requested changes
Oct 31, 2019
babolivier
force-pushed
the
babolivier/msc2326_bg_update
branch
from
November 4, 2019 10:00
573f782
to
3b29a73
Compare
5 tasks
richvdh
previously requested changes
Nov 7, 2019
This reverts commit 1186612.
richvdh
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than these two nits
Co-Authored-By: Richard van der Hoff <[email protected]>
Co-Authored-By: Richard van der Hoff <[email protected]>
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '46e5db9eb': Update synapse/storage/data_stores/main/events_bg_updates.py Update synapse/storage/data_stores/main/events_bg_updates.py Copy results Revert "Back to using cursor_to_dict" Back to using cursor_to_dict Initialise value before looping Incorporate review Fix field name Update insert Update changelog Print out the actual number of affected rows Correctly order results TODO Fix exit condition Lint Changelog Don't try to process events we already have a label for Use a sensible default value for labels Use the right format for rows MSC2326: Add background update to take previous events into account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #6301
Add a background update that goes through all of the events in the server's database and, for each event that has at least one label, saves those labels to the
event_labels
table, so that events sent prior to upgrading Synapse can be filtered by labels (like the ones sent after the upgrade).Fixes #6288