Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Reduce verbosity of URL cache cleanup. #7295

Merged
merged 3 commits into from
Apr 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7295.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reduce log verbosity of url cache cleanup tasks.
9 changes: 7 additions & 2 deletions synapse/rest/media/v1/preview_url_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ async def _expire_url_cache_data(self):

now = self.clock.time_msec()

logger.info("Running url preview cache expiry")
logger.debug("Running url preview cache expiry")

if not (await self.store.db.updates.has_completed_background_updates()):
logger.info("Still running DB updates; skipping expiry")
Expand Down Expand Up @@ -435,6 +435,8 @@ async def _expire_url_cache_data(self):

if removed_media:
logger.info("Deleted %d entries from url cache", len(removed_media))
else:
logger.debug("No entries removed from url cache")

# Now we delete old images associated with the url cache.
# These may be cached for a bit on the client (i.e., they
Expand Down Expand Up @@ -481,7 +483,10 @@ async def _expire_url_cache_data(self):

await self.store.delete_url_cache_media(removed_media)

logger.info("Deleted %d media from url cache", len(removed_media))
if removed_media:
logger.info("Deleted %d media from url cache", len(removed_media))
else:
logger.debug("No media removed from url cache")
michaelkaye marked this conversation as resolved.
Show resolved Hide resolved


def decode_and_calc_og(body, media_uri, request_encoding=None):
Expand Down