Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use mock from the stdlib. #7709

Closed
wants to merge 2 commits into from
Closed

Use mock from the stdlib. #7709

wants to merge 2 commits into from

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 16, 2020

Per @anoadragon453's suggestion from looking at #7704 this switches from using the mock package to the one in the standard library.

Done with some sed magic + isort.

  • Switches from importing mock, to importing it as a submodule of unittest.
  • Stop installing the mock package.

This affects test only code so should be fine if unit tests pass.

@clokep clokep requested review from a team and removed request for a team June 16, 2020 15:54
@clokep
Copy link
Member Author

clokep commented Jun 16, 2020

Looks like we use a few things on Mock that is only available in require Python >= 3.6. 😢 That's quite frustrating.

@clokep
Copy link
Member Author

clokep commented Jun 16, 2020

Unfortunately I think the best thing to do here is close this for now, we can re-open it once Python 3.5 support is dropped.

@clokep clokep closed this Jun 16, 2020
@clokep clokep mentioned this pull request Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant