Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert room list handler to async/await. #7912

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Convert room list handler to async/await. #7912

merged 2 commits into from
Jul 21, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 20, 2020

This converts the remaining inlineCallbacks and cachedInlineCallbacks in the room list handler to async / await.

It seems like the appropriate is:

@cachedInlineCallbacks
def foo():
     yield blah

becomes the following:

@cached
async def foo():
    await blah

@clokep clokep requested a review from a team July 20, 2020 17:52
anoadragon453
anoadragon453 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise. I believe you are correct for the @cached assumption.

changelog.d/7912.misc Outdated Show resolved Hide resolved
@clokep @anoadragon453
Update changelog
3c5170b 
Co-authored-by: Andrew Morgan <[email protected]>
@clokep clokep merged commit de11906 into develop Jul 21, 2020
@clokep clokep deleted the clokep/async-room-list branch July 21, 2020 11:51
@clokep clokep mentioned this pull request Jul 30, 2020
Closed
48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge commit 'de119063f' into anoa/dinsic_release_1_18_x
a567e76 
* commit 'de119063f': (31 commits)
  Convert room list handler to async/await. (#7912)
  Element CSS and logo in email templates (#7919)
  Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914)
  Remove unused code from synapse.logging.utils. (#7897)
  Fix a typo in the sample config. (#7890)
  Fix deprecation warning: import ABC from collections.abc (#7892)
  Change sample config's postgres user to synapse_user (#7889)
  Fix deprecation warning due to invalid escape sequences (#7895)
  Remove Ubuntu Eoan that is now EOL (#7888)
  Fix the trace function for async functions. (#7872)
  Add help for creating a user via docker (#7885)
  Switch to Debian:Slim from Alpine for the docker image (#7839)
  Stop using 'device_max_stream_id' (#7882)
  Fix TypeError in synapse.notifier (#7880)
  Add a default limit (of 100) to get/sync operations. (#7858)
  Change "unknown room ver" logging to warning. (#7881)
  Convert device handler to async/await (#7871)
  Convert synapse.app to async/await. (#7868)
  Convert _base, profile, and _receipts handlers to async/await (#7860)
  Add admin endpoint to get members in a room. (#7842)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @anoadragon453