Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Only log if an existing localpart was found, extend logged info #8773

Merged
merged 5 commits into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8773.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minor log line improvements for the SSO mapping code used to generate Matrix IDs from SSO IDs.
5 changes: 3 additions & 2 deletions synapse/handlers/saml_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ async def _map_saml_response_to_user(
user_id = UserID(
map_username_to_mxid_localpart(attrval), self.server_name
).to_string()
logger.info(

logger.debug(
"Looking for existing account based on mapped %s %s",
self._grandfathered_mxid_source_attribute,
user_id,
Expand Down Expand Up @@ -324,7 +325,7 @@ async def _map_saml_response_to_user(
if contains_invalid_mxid_characters(localpart):
raise MappingException("localpart is invalid: %s" % (localpart,))

logger.info("Mapped SAML user to local part %s", localpart)
logger.debug("Mapped SAML user to local part %s", localpart)
registered_user_id = await self._registration_handler.register_user(
localpart=localpart,
default_display_name=displayname,
Expand Down
12 changes: 9 additions & 3 deletions synapse/handlers/sso.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,25 @@ async def get_sso_user_by_remote_user_id(
Returns:
The mxid of a previously seen user.
"""
# Check if we already have a mapping for this user.
logger.info(
clokep marked this conversation as resolved.
Show resolved Hide resolved
logger.debug(
"Looking for existing mapping for user %s:%s",
auth_provider_id,
remote_user_id,
)

# Check if we already have a mapping for this user.
previously_registered_user_id = await self.store.get_user_by_external_id(
auth_provider_id, remote_user_id,
)

# A match was found, return the user ID.
if previously_registered_user_id is not None:
logger.info("Found existing mapping %s", previously_registered_user_id)
logger.info(
"Found existing mapping for IdP '%s' and remote_user_id '%s': %s",
auth_provider_id,
remote_user_id,
previously_registered_user_id,
)
return previously_registered_user_id

# No match.
Expand Down