Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dendrite dockerfile to Go 1.19.1 #1292

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Update Dendrite dockerfile to Go 1.19.1 #1292

merged 2 commits into from
Sep 27, 2022

Conversation

0x1a8510f2
Copy link
Contributor

Needed for matrix-org/dendrite#2714 but also just a good idea in general :P

@0x1a8510f2 0x1a8510f2 requested a review from a team as a code owner September 15, 2022 23:18
@DMRobertson DMRobertson requested review from a team and removed request for a team September 16, 2022 11:49
@squahtx squahtx requested review from a team and removed request for a team September 16, 2022 11:49
@richvdh
Copy link
Member

richvdh commented Sep 22, 2022

1.19.1 of what?

@0x1a8510f2 0x1a8510f2 changed the title Update Dendrite dockerfile to 1.19.1 Update Dendrite dockerfile to Go 1.19.1 Sep 22, 2022
@0x1a8510f2
Copy link
Contributor Author

Ah, sorry. Go 1.19.1.

@0x1a8510f2 0x1a8510f2 mentioned this pull request Sep 23, 2022
Closed
2 tasks
S7evinK
S7evinK approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@S7evinK S7evinK merged commit 221e1bb into matrix-org:develop Sep 27, 2022
@0x1a8510f2 0x1a8510f2 deleted the update-go branch September 27, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S7evinK S7evinK S7evinK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x1a8510f2 @richvdh @S7evinK