Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbar renders images at "non-retina" resolution #316

Closed
SCdF opened this issue Apr 8, 2016 · 4 comments
Closed

Bitbar renders images at "non-retina" resolution #316

SCdF opened this issue Apr 8, 2016 · 4 comments

Comments

@SCdF
Copy link

SCdF commented Apr 8, 2016

So apologies if I've got this horribly wrong, but I think Bitbar doesn't correctly support retina-quality images. Here:

var TWITCH_ICON_16 = "AAABAAEAEBAAAAAAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAQAQAAAAAAAAAAAAAAAAA" +
    "AAAAAAD///8B////Af///wH///8B////AaVBZP+lQWT/pUFk/6VBZE////8B////Af///wH///8B" +
// <snip>
console.log('|image="'+ TWITCH_ICON_16 + '"');

…is me using a 16x16 favicon, rendered on a normal dpi display:

image
(emoji for scale)
Which looks great! Here is the same situation rendered a retina display:

image

Blocky, as expected. It looks like 16:16 images are (roughly) the right non-retina size for the tray, which would imply doubling the res would be the correct retina resolution.

For funzies:

image

It also looks the same on my retina display:

image

So from this it looks like to me that Bitbar renders image at "standard" resolution, as opposed (or not as well as) the doubled retina resolution.

If you want to fix this, I'm not exactly sure what the correct fix for this would be (I haven't really dealt with retina vs. non-retina before). I guess you could have an image= and a retinaImage= base64 parameter, or just change image to render at retina resolution.

@iosdeveloper
Copy link
Collaborator

Don't double the size, double the resolution (see #314).

@SCdF
Copy link
Author

SCdF commented Apr 8, 2016

Ahh cool, thanks. Apologies, I should have searched closed tickets!

@SCdF SCdF closed this as completed Apr 8, 2016
@iosdeveloper
Copy link
Collaborator

No worries. We should really mention this somewhere.

@mm2270
Copy link

mm2270 commented Apr 8, 2016

Yeah, it probably should get mentioned somewhere in the plugin development documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants