Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Glue Job permissions #137

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Add AWS Glue Job permissions #137

merged 4 commits into from
Apr 15, 2021

Conversation

ichekaldin
Copy link
Contributor

@ichekaldin ichekaldin commented Mar 16, 2021

This allows AWS Glue integration tests to be executed, per @tremble
recommendation in ansible-collections/community.aws#480

This replaces #95 which appears to have been abandoned.

This allows AWS Glue integration tests to be executed, per @tremble
recommendation in #95
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ichekaldin, the policies look good but we'll also need a new class added to the terminator lambda for Glue Jobs. The terminator is a lambda function that runs in our CI account and deletes resources that have been online for longer than a set time, in case a CI job fails to clean up after itself for some reason.

You can see an example of the class for cleaning up glue connections here:
https://github.com/mattclay/aws-terminator/blob/master/aws/terminator/data_services.py#L54-L72

@ichekaldin
Copy link
Contributor Author

@jillr I added the class to cleanup Glue jobs. Thank you!

@ichekaldin
Copy link
Contributor Author

@jillr Is there anything else that I'm missing for this PR?

@jillr
Copy link
Collaborator

jillr commented Apr 2, 2021

Hi @ichekaldin, apologies for the delay I was out of the office for a bit - I work through this queue and do policy deploys on Thursdays usually. These seem good but I'm not able to test successfully with 480, I'll leave some comments over there.

@jillr jillr merged commit d195380 into mattclay:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants