Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make compilationJobs argument optional at TASK_COMPILE_SOLIDITY_… #1322

Merged

Conversation

kiriyaga-txfusion
Copy link
Contributor

…GET_SOLC_BUILD subtask

What 💻

  • Make compilationJobs argument optional at TASK_COMPILE_SOLIDITY_GET_SOLC_BUILD subtask

Why ✋

  • Some users do not use the extended Hardhat subtask, so we will make this additional argument optional. This way, the compilation process will not default to using the forked Era Solidity compiler. When used in this manner, there may be differences in bytecode because, with the argument enabled, the forked Solidity compiler is used; otherwise, the native compiler will be utilized.

Opened to fix and replace this PR #1301

@kiriyaga-txfusion kiriyaga-txfusion merged commit 6877903 into main Aug 26, 2024
19 of 21 checks passed
@kiriyaga-txfusion kiriyaga-txfusion deleted the kiriyaga-txfusion-solc-compilation-job-optional branch August 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants