feat: implement the get solc task in a hardhat-compatible way #1301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
This PR adjusts the get solc job to be implemented in a hardhat compatible manner wrt job params:
https://github.com/NomicFoundation/hardhat/blob/93b30d531d1bb1d766bdf2105cd04fa50fef12aa/packages/hardhat-core/src/builtin-tasks/compile.ts#L561-L563
The original job only accepts
quiet
andsolcVersion
params, so there's a discrepancy between hardhat and hardhat-zksyncWhy ✋
This is to make it easier to use when someone needs to obtain the solc build when compiling in zksync mode. In the Safe project, we do quite a few compilations from strings for tests, e.g:
and the difference between evm/zkvm behaviours makes us write hacky code
Evidence 📷
The tests passed on my computer; however, the runs seem to be non-deterministic, and every third or so run fails. I'm not sure if it's related to my changes