-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SignatureBasedPaymaster contract #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dutterbutter
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great use case for paymaster usage and a fantastic external contribution. Thank you very much for the time and energy on this. 🚀 🙏
dutterbutter
approved these changes
Mar 13, 2024
yay! 💫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paymaster Description
Objective: Implement a
SignatureBasedPaymaster
contract that covers gas fees for users based on valid signature provided by the signer of the paymaster contract.Changes introduced in this PR:
SignatureBasedPaymaster
contract.SignatureBasedPaymaster
matching repository standards.SignatureBasedPaymaster
matching repository standards.Additional Information
Functionality:
innerInputs
whether or not the user's transaction shall be allowed to proceed or not.(user address, last timestamp, nonces)
.innerInputs
in paymaster params.transaction.from
,block.timestamp
andnonces
to ensure only valid users are allowed to use paymaster.Security Considerations:
transaction.from
to ensure correct user has sent transaction.