-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Brush up repo for publishing (pt. 3) #60
refactor: Brush up repo for publishing (pt. 3) #60
Conversation
6b10eeb
to
d7b696a
Compare
d7b696a
to
ab46e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can split the PR into parts if it makes it more reviewable.
- There are some debatable decisions (e.g., enabling pedantic clippy lints – I think it makes code better, but this is subjective).
- The built crate docs are available.
Here's the corresponding PR on the Era side: matter-labs/zksync-era#2883. There's performance regression on some iai benches (order of 2–3%); will investigate its cause. |
fcdbee7
to
fbabb85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once the remaining few comments are implemented.
I will fix the invalid instruction unsoundness in a separate PR.
What ❔
PtrOp
trait).Snapshot
andStorageChange
types.zksync_vm2_interface
as theinterface
module instead of re-exporting its items.offset_from
calls.Why ❔
Part of preparations for publishing the VM.
Checklist
cargo fmt
andcargo clippy
.