Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo.toml files point to private repositories and v1.3.1 branches #2

Closed
Nathan-Franck opened this issue Feb 17, 2023 · 4 comments
Closed

Comments

@Nathan-Franck
Copy link

I understand with the re-branding that there's a lot of churn with your files, here's one you missed ---

I'm trying to run through the install steps and am getting stuck doing a cargo build - all the dependent cargo packages in your organization are pointing to non-'era-' repositories and to a 'v1.3.1' instead of 'main' branch. I was able to text-replace all the cargo.toml files in this repository, but now some dependent packages are themselves trying to find their own non-'era-' repositories so it's best to let you know!

@bradyjoestar
Copy link

yeah, same to me

@arose0
Copy link

arose0 commented Feb 17, 2023

Thanks for flagging - all of the dependencies are open source, but of course the paths need updating. If you want to get unblocked urgently, you can change these yourself but of course this isn't ideal and with the name changes they may not all be obvious.

We'll have a fix for this up very soon! cc @shahar4 FYI.

@greyblake
Copy link

Same here.
cargo check fails to clone https://github.com/matter-labs/zk_evm.git:

error: failed to get `zk_evm` as a dependency of package `zksync_utils v1.0.0 

@shahar4
Copy link
Collaborator

shahar4 commented Mar 15, 2023

Please try to run the project now. All the private deps were updated and the project is runnable using all public repos. Thanks for raising this! @Nathan-Franck @bradyjoestar @greyblake

@shahar4 shahar4 closed this as completed Mar 23, 2023
mm-zk pushed a commit that referenced this issue Nov 27, 2023
SuccinctPaul pushed a commit to SuccinctPaul/zksync-era that referenced this issue Apr 19, 2024
Artemka374 added a commit that referenced this issue May 29, 2024
Artemka374 added a commit that referenced this issue May 31, 2024
danielCalbonero12345 added a commit to danielCalbonero12345/zksync-era that referenced this issue Jun 6, 2024
AnastasiiaVashchuk added a commit that referenced this issue Jun 12, 2024
Artemka374 added a commit that referenced this issue Aug 15, 2024
tomg10 added a commit that referenced this issue Sep 10, 2024
Signed-off-by: tomg10 <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
## What ❔

Introduce WitnessGenerator trait
Rename some methods

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants