Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integrate tracers and implement circuits tracer in vm2 #2653

Merged
merged 68 commits into from
Sep 4, 2024
Merged

feat: Integrate tracers and implement circuits tracer in vm2 #2653

merged 68 commits into from
Sep 4, 2024

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Aug 14, 2024 •
edited by slowli
Loading

What ❔

Integrates tracers support into the codebase and implements the circuits tracer.

Why ❔

Tracers are required for some VM applications, e.g. to determine batch seal criteria and for tracing calls.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

montekki and others added 30 commits August 13, 2024 16:40
@montekki
integrate vm being generic over tracer type
cd59c72
@montekki
initial skeleton of tracers interface for vm2
0f23f10
@montekki
wip code, some of the stats work some dont
bb97637
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
4c2c4c3
@montekki
all except storage statistics is supposed to work
4e195f8
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
7cb67fc
@montekki
reset to main
a9e9893
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
1591b7b
@montekki
newer interface
86fd8de
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
097fd1a
@montekki
per opcode statistics
236ab63
@joonazan
update vm2 ref
2c35dd1
@joonazan
vm2 version that fixes segfault
e491ca0
@joonazan
save pc in vm snapshots, not in integration
5da39a8
@montekki
bump vm2 to segfault fix
214b97a
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
f56ca44
@montekki
count precompile cycles
5c64fe7
@montekki
code decommitter stats
3c7aaea
@montekki
updates to newest vm2 code
cd4e4cd
@montekki
storage stats
66a02a1
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
4a565b0
@montekki
fix clippy
adad0e9
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
fd708cf
@joonazan
reduce the tracer to just increment one number
8198784
@montekki
integrate newer changes
ad3613c
@montekki
fix clippy
57ea5d0
@montekki
increase timeout
746a788
@montekki
Merge branch 'main' into fvs-vm-fast-circuits-tracer
dde82ed
@montekki
Revert "reduce the tracer to just increment one number"
716ea2e 
This reverts commit 8198784.
@montekki
fix secpverify counter
921b007
slowli
slowli reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is performance degradation on iai benches expected? (AFAIU, it is real degradation compared to the main branch, e.g. judging by these results on main.) Have you checked whether it translates to the real-time degradation?

core/lib/contracts/src/lib.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/tests/tester/transaction_test_info.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/circuits_tracer.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/vm.rs Outdated Show resolved Hide resolved
etc/contracts-test-data/contracts/failed-call/failed_call.sol Outdated Show resolved Hide resolved
etc/contracts-test-data/contracts/failed-call/failed_call.sol Outdated Show resolved Hide resolved
@joonazan
Copy link
Contributor

joonazan commented Sep 3, 2024

The slowdown is real but mostly under 10%. heap_read_write shows +15% on my M1 even though it shows no change in iai.
This can be investigated later when we want to really optimize performance.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Detected VM performance changes

Benchmark name change in estimated runtime change in number of opcodes executed
event_spam +5.9% +0 (NaN%)
decode_shl_sub +17.4% +0 (NaN%)
slot_hash_collision +11.4% +0 (NaN%)
access_memory +13.8% +0 (NaN%)
write_and_decode +11.2% +0 (NaN%)

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently.

@slowli slowli changed the title fix: integrate tracers and implement circuits tracer in vm2 feat: Integrate tracers and implement circuits tracer in vm2 Sep 4, 2024
@joonazan joonazan added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@slowli slowli added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 87b02e3 Sep 4, 2024
56 checks passed
@slowli slowli deleted the fvs-vm-fast-circuits-tracer branch September 4, 2024 07:03
This was referenced Sep 4, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
@zksync-era-bot
chore(main): release core 24.24.0 (#2773)
fcffb06 
🤖 I have created a release *beep* *boop*
---


##
[24.24.0](core-v24.23.0...core-v24.24.0)
(2024-09-05)


### Features

* conditional cbt l1 updates
([#2748](#2748))
([6d18061](6d18061))
* **eth-watch:** do not query events from earliest block
([#2810](#2810))
([1da3f7e](1da3f7e))
* **genesis:** Validate genesis config against L1
([#2786](#2786))
([b2dd9a5](b2dd9a5))
* Integrate tracers and implement circuits tracer in vm2
([#2653](#2653))
([87b02e3](87b02e3))
* Move prover data to
/home/popzxc/workspace/current/zksync-era/prover/data
([#2778](#2778))
([62e4d46](62e4d46))
* Remove prover db from house keeper
([#2795](#2795))
([85b7346](85b7346))
* **vm-runner:** Implement batch data prefetching
([#2724](#2724))
([d01840d](d01840d))
* **vm:** Extract batch executor to separate crate
([#2702](#2702))
([b82dfa4](b82dfa4))
* **vm:** Simplify VM interface
([#2760](#2760))
([c3bde47](c3bde47))
* **zk_toolbox:** add multi-chain CI integration test
([#2594](#2594))
([05c940e](05c940e))


### Bug Fixes

* **config:** Do not panic for observability config
([#2639](#2639))
([1e768d4](1e768d4))
* **core:** Batched event processing support for Reth
([#2623](#2623))
([958dfdc](958dfdc))
* return correct witness inputs
([#2770](#2770))
([2516e2e](2516e2e))
* **tee-prover:** increase retries to reduce spurious alerts
([#2776](#2776))
([4fdc806](4fdc806))
* **tee-prover:** mitigate panic on redeployments
([#2764](#2764))
([178b386](178b386))
* **tee:** lowercase enum TEE types
([#2798](#2798))
([0f2f9bd](0f2f9bd))
* **vm-runner:** Fix statement timeouts in VM playground
([#2772](#2772))
([d3cd553](d3cd553))


### Performance Improvements

* **vm:** Fix VM performance regression on CI loadtest
([#2782](#2782))
([bc0d7d5](bc0d7d5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@zksync-era-bot
chore(main): release prover 16.6.0 (#2761)
e95f50a 
🤖 I have created a release *beep* *boop*
---


##
[16.6.0](prover-v16.5.0...prover-v16.6.0)
(2024-10-31)


### Features

* (DB migration) Rename recursion_scheduler_level_vk_hash to
snark_wrapper_vk_hash
([#2809](#2809))
([64f9551](64f9551))
* Add initial version prover_autoscaler
([#2993](#2993))
([ebf9604](ebf9604))
* added seed_peers to consensus global config
([#2920](#2920))
([e9d1d90](e9d1d90))
* attester committees data extractor (BFT-434)
([#2684](#2684))
([92dde03](92dde03))
* Bump crypto and protocol deps
([#2825](#2825))
([a5ffaf1](a5ffaf1))
* **circuit_prover:** Add circuit prover
([#2908](#2908))
([48317e6](48317e6))
* **consensus:** Support for syncing blocks before consensus genesis
over p2p network
([#3040](#3040))
([d3edc3d](d3edc3d))
* **da-clients:** add secrets
([#2954](#2954))
([f4631e4](f4631e4))
* gateway preparation
([#3006](#3006))
([16f2757](16f2757))
* Integrate tracers and implement circuits tracer in vm2
([#2653](#2653))
([87b02e3](87b02e3))
* Move prover data to
/home/popzxc/workspace/current/zksync-era/prover/data
([#2778](#2778))
([62e4d46](62e4d46))
* Prover e2e test
([#2975](#2975))
([0edd796](0edd796))
* **prover:** add CLI option to run prover with max allocation
([#2794](#2794))
([35e4cae](35e4cae))
* **prover:** Add endpoint to PJM to get queue reports
([#2918](#2918))
([2cec83f](2cec83f))
* **prover:** Add error to panic message of prover
([#2807](#2807))
([6e057eb](6e057eb))
* **prover:** Add min_provers and dry_run features. Improve metrics and
test. ([#3129](#3129))
([7c28964](7c28964))
* **prover:** Add scale failure events watching and pods eviction.
([#3175](#3175))
([dd166f8](dd166f8))
* **prover:** Add sending scale requests for Scaler targets
([#3194](#3194))
([767c5bc](767c5bc))
* **prover:** Add support for scaling WGs and compressor
([#3179](#3179))
([c41db9e](c41db9e))
* **prover:** Autoscaler sends scale request to appropriate agents.
([#3150](#3150))
([bfedac0](bfedac0))
* **prover:** Extract keystore into a separate crate
([#2797](#2797))
([e239260](e239260))
* **prover:** Optimize setup keys loading
([#2847](#2847))
([19887ef](19887ef))
* **prover:** Refactor WitnessGenerator
([#2845](#2845))
([934634b](934634b))
* **prover:** Update witness generator to zkevm_test_harness 0.150.6
([#3029](#3029))
([2151c28](2151c28))
* **prover:** Use query macro instead string literals for queries
([#2930](#2930))
([1cf959d](1cf959d))
* **prover:** WG refactoring
[#3](#3)
([#2942](#2942))
([df68762](df68762))
* **prover:** WitnessGenerator refactoring
[#2](#2)
([#2899](#2899))
([36e5340](36e5340))
* Refactor metrics/make API use binaries
([#2735](#2735))
([8ed086a](8ed086a))
* Remove prover db from house keeper
([#2795](#2795))
([85b7346](85b7346))
* **tee:** use hex serialization for RPC responses
([#2887](#2887))
([abe0440](abe0440))
* **utils:** Rework locate_workspace, introduce Workspace type
([#2830](#2830))
([d256092](d256092))
* vm2 tracers can access storage
([#3114](#3114))
([e466b52](e466b52))
* **vm:** Do not panic on VM divergence
([#2705](#2705))
([7aa5721](7aa5721))
* **vm:** EVM emulator support – base
([#2979](#2979))
([deafa46](deafa46))
* **vm:** Extract batch executor to separate crate
([#2702](#2702))
([b82dfa4](b82dfa4))
* **zk_toolbox:** `zk_supervisor prover` subcommand
([#2820](#2820))
([3506731](3506731))
* **zk_toolbox:** Add external_node consensus support
([#2821](#2821))
([4a10d7d](4a10d7d))
* **zk_toolbox:** Add SQL format for zk supervisor
([#2950](#2950))
([540e5d7](540e5d7))
* **zk_toolbox:** deploy legacy bridge
([#2837](#2837))
([93b4e08](93b4e08))
* **zk_toolbox:** Redesign zk_toolbox commands
([#3003](#3003))
([114834f](114834f))
* **zkstack_cli:** Build dependencies at zkstack build time
([#3157](#3157))
([724d9a9](724d9a9))


### Bug Fixes

* allow compilation under current toolchain
([#3176](#3176))
([89eadd3](89eadd3))
* **api:** Return correct flat call tracer
([#2917](#2917))
([218646a](218646a))
* count SECP256 precompile to account validation gas limit as well
([#2859](#2859))
([fee0c2a](fee0c2a))
* Fix Doc lint.
([#3158](#3158))
([c79949b](c79949b))
* ignore unknown fields in rpc json response
([#2962](#2962))
([692ea73](692ea73))
* **prover:** Do not exit on missing watcher data.
([#3119](#3119))
([76ed6d9](76ed6d9))
* **prover:** fix setup_metadata_to_setup_data_key
([#2875](#2875))
([4ae5a93](4ae5a93))
* **prover:** Run for zero queue to allow scaling down to 0
([#3115](#3115))
([bbe1919](bbe1919))
* **tee_verifier:** correctly initialize storage for re-execution
([#3017](#3017))
([9d88373](9d88373))
* **vm:** Prepare new VM for use in API server and fix divergences
([#2994](#2994))
([741b77e](741b77e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@joonazan joonazan joonazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montekki @joonazan @slowli