refactor: Split the rest of the zksync_core #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
commented
May 15, 2024
Deniallugo
reviewed
May 15, 2024
6 tasks
Deniallugo
approved these changes
May 15, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
….rs" (#2945) ## What ❔ This PR fixes 2 invalid links in the documents which was caused by refactor (refactor: Split the rest of the zksync_core (#1940)) ## Why ❔ Unclarity in documentation ## Checklist - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts remaining (strategically meaningful) parts of
zksync_core.This was a hell of a feat to de-entangle all of these interdependencies (especially in tests, oh boy).
The following crates were extracted:
Contents of
zksync_core::utilswere moved to other places.zksync_corewas renamed tozksync_core_leftovers(and will be removed when we migrate to the framework).Once this is merged, I'll also update settings for infra to enable logs for new crates.