Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state-keeper): Add L2ToL1LogsCriterion #195

Merged

Conversation

perekopskiy
Copy link
Contributor

What ❔

Added L1 batch seal criterion for number of L2 to L1 logs

Why ❔

Number of logs must be <= 512 per batch.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@perekopskiy perekopskiy requested a review from a team as a code owner October 11, 2023 15:28
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c175033) 32.74% compared to head (7f50a5c) 32.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   32.74%   32.73%   -0.01%     
==========================================
  Files         536      536              
  Lines       28122    28125       +3     
==========================================
  Hits         9208     9208              
- Misses      18914    18917       +3     
Files Coverage Δ
...c/state_keeper/seal_criteria/conditional_sealer.rs 50.00% <ø> (ø)
...r/seal_criteria/criteria/geometry_seal_criteria.rs 50.00% <50.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perekopskiy perekopskiy added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@perekopskiy perekopskiy added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 64459b2 Oct 11, 2023
23 checks passed
@perekopskiy perekopskiy deleted the perekopskiy-pla-607-add-sealcriterion-for-l2-l1-logs branch October 11, 2023 17:50
github-merge-queue bot pushed a commit that referenced this pull request Oct 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.0.2](core-v16.0.1...core-v16.0.2)
(2023-10-12)


### Bug Fixes

* **API:** return correct v value for Legacy tx
([#154](#154))
([ed502ea](ed502ea))
* **API:** U256 for chainId in api::Transaction struct
([#211](#211))
([ca98a1c](ca98a1c))
* **prover:** Fix statistic query
([#193](#193))
([5499093](5499093))
* **state-keeper:** Add L2ToL1LogsCriterion
([#195](#195))
([64459b2](64459b2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Danil <[email protected]>
Co-authored-by: Danil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants