feat(zk_toolbox): Ease requirements, add option to download setup keys #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/node/external_proof_integration_api/src/processor.rs # zk_toolbox/crates/zk_inception/src/commands/prover/run.rs
# Conflicts: # zk_toolbox/crates/zk_inception/src/commands/prover/generate_sk.rs
EmilLuta
reviewed
Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
Follow-up to #2784 Forgot to update one dockerfile.
Deniallugo
reviewed
Sep 3, 2024
zk_toolbox/crates/zk_inception/src/commands/prover/setup_keys.rs
Outdated
Show resolved
Hide resolved
zk_toolbox/crates/zk_inception/src/commands/prover/setup_keys.rs
Outdated
Show resolved
Hide resolved
Artemka374
force-pushed
the
afo/zki-requirements-setup-keys
branch
from
c0d12ce
to
1b60bdc
Compare
Deniallugo
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Make some of the prerequisites in prover subcommand optional(checks are enforced only when the prerequisite is needed)
Add option to download setup keys instead of generating
Why ❔
Checklist
zk fmtandzk lint.