Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting spec.ingressClassName #288

Open
bbaptist opened this issue Dec 30, 2021 · 4 comments
Open

Support setting spec.ingressClassName #288

bbaptist opened this issue Dec 30, 2021 · 4 comments

Comments

@bbaptist
Copy link

The new version of the Gitlab Helm chart uses spec.ingressClassName instead of an annotation of kubernetes.io/ingress.class. This means that the current charts won't work with the latest Gitlab Chart Version v5.6.0. Being able to set this value would be a great addition.

Thanks!
@bbaptist
Copy link
Author

Oh, this is for the mattermost-team-edition ingress.yaml template.

@nicholasrobertm
Copy link

This issue actually exists for all of the charts in this repo FYI (Tested with focalboard)

@bbaptist bbaptist mentioned this issue Jun 8, 2022
Open
@pablo-suazo pablo-suazo mentioned this issue Feb 17, 2023
Merged
spirosoik pushed a commit that referenced this issue Jun 20, 2023
@pablo-suazo @mattermost-build
Fix for supporting ingressClassName (#389)
e370f73 
Adds ingressClassName support to mattermost-team chart

Fixes issue #288

---------

Co-authored-by: Mattermost Build <[email protected]>
@mustdiechik
Copy link
Contributor

/close

@kgriffiths
Copy link

This was fixed for the Team chart only, the Enterprise version of the chart is still missing ingressClassName as a chart value, which prevents deploying Mattermost with Ingress. ingressClassName is a required field for current versions of the Ingress resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicholasrobertm @kgriffiths @bbaptist @mustdiechik