Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for zoom plugin summarization of chats and transcriptions #184

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

jespino
Copy link
Member

@jespino jespino commented May 15, 2024

Adding the summarization support for zoom plugin for transcriptions and chat history.

@jespino jespino requested a review from crspeller May 18, 2024 15:40
server/api_post.go Outdated Show resolved Hide resolved
if err != nil {
return fmt.Errorf("unable to parse transcription file: %w", err)
var transcription *subtitles.Subtitles
if transcriptionFilePost.Type == "custom_zoom_chat" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda an awkward way to do this. It's not really a meeting we are summarizing here, just the chat from it.
I wonder if we could just incorporate the chat into the main summary somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try that, but my concern is sometimes the chat deviates from the regular conversation and it is out-of-sync with the regular conversation. I think having a summary of both independently can work well. Also, the transcription and the chat are delivered in different webhooks, so it makes the things way more complicated. I would suggest to go with this approach and we can address that later and have another thing that is combining both. But I think for now this is good enough.

server/ai/subtitles/subtitles.go Outdated Show resolved Hide resolved
@jespino jespino requested a review from crspeller May 24, 2024 13:08
@jespino jespino merged commit ad2dc86 into mattermost:master Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants