Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding i18n support to the frontend #194

Merged
merged 17 commits into from
Jun 3, 2024

Conversation

jespino
Copy link
Member

@jespino jespino commented May 30, 2024

Adding the i18n support to the fronted and adding the spanish translations

Closes #

Description

@jespino jespino requested a review from crspeller May 30, 2024 15:18
Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just a couple comments.

webapp/src/components/bot_slector.tsx Outdated Show resolved Hide resolved
webapp/src/components/rhs/rhs_new_tab.tsx Show resolved Hide resolved
webapp/src/index.tsx Outdated Show resolved Hide resolved
@jespino jespino requested a review from crspeller May 31, 2024 08:15
@jprusch
Copy link

jprusch commented Jun 3, 2024

What would be the best way to add another language? Clone & create a PR? Hook the plugin up to Weblate?

@jespino
Copy link
Member Author

jespino commented Jun 3, 2024

@jprusch the idea is to hook the plugin into Weblate as soon as this gets merged into the master branch.

@crspeller crspeller merged commit 9e2ab55 into mattermost:master Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants