Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add valiation to username for bot. #228

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add valiation to username for bot. #228

merged 1 commit into from
Aug 5, 2024

Conversation

crspeller
Copy link
Member

No description provided.

enzowritescode
enzowritescode requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@enzowritescode enzowritescode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front-end validation is good because it can eliminate the number of API requests but it can always be bypassed. Validation also needs to be done on the back-end.

@crspeller
Copy link
Member Author

@enzowritescode Validation is already done on the back-end. It won't create an invalid bot.

@crspeller crspeller merged commit aabcab0 into master Aug 5, 2024
5 checks passed
@crspeller crspeller deleted the username-validation-MM-59946 branch August 5, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzowritescode enzowritescode enzowritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crspeller @enzowritescode