Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error code extraction #129

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix error code extraction #129

merged 1 commit into from
Oct 3, 2024

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Oct 1, 2024

Summary

The error code extraction was not working. Added tests and fixed it.

Ticket Link

Part of https://mattermost.atlassian.net/browse/MM-56827

@larkox larkox added the 1: Dev Review Requires review by a core commiter label Oct 1, 2024
@larkox larkox requested review from agnivade and enahum October 1, 2024 10:33
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This just shows the value of unit tests and reviewing the PR properly. I am to blame as well because I missed that other error types could also be returned from the function.

@larkox larkox added 2: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Oct 3, 2024
@larkox larkox merged commit 79b00fc into master Oct 3, 2024
5 checks passed
@larkox larkox deleted the fixErrorCodeExtraction branch October 3, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants