Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-13026 : Migrate mattermost-utilities/github_jira_tools from python to go #77

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

VineetKSingh
Copy link

Summary

  • Develop functionality for creating labels on github from given input.
  • Renaming of existing github folder to github_utils. The folder name clashes with the go github lib making it difficult to navigate.
  • Updated github dependency version from v35 to v52.
  • Updated code according to the new github dependency.
  • Fixed the creategithub issue code throwing http 415.

The code has been tested with personal atlassian tokens, board and custom fields to make sure it generates github issues, applies the required labels and writes the github issue link back to jira custom field.

JIRA: https://mattermost.atlassian.net/browse/MM-19977

Ticket Link: mattermost/mattermost#13026

@mattermost-build
Copy link

Hello @VineetKSingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei hanzei requested a review from jespino May 25, 2023 14:23
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label May 25, 2023
@VineetKSingh
Copy link
Author

/check-cla

@M-ZubairAhmed M-ZubairAhmed changed the title MM 13026 MM-13026 : Migrate mattermost-utilities/github_jira_tools from python to go May 26, 2023
@mattermost-build
Copy link

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@M-ZubairAhmed
Copy link
Member

@jespino can you please look at this to see if this is still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer Lifecycle/1:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants