MM-3943 : Migrate to go-i18n 2.X #21327
Open
+235
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
KuSh
changed the title
KuSh
changed the title
|
Re-assigning to @laneycs's team as per AORs |
KuSh
force-pushed
the
GH-5267
branch
2 times, most recently
from
51bffd8
to
1dd3414
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
It's not stale on my side. I'm just waiting for a review by @gabrieljackson and @laneycs |
laneycs
previously approved these changes
Dec 7, 2022
|
Hi @isacikgoz, is there someone else than @gabrieljackson that can review this PR ? It seems to have fallen off its radar |
This comment was marked as outdated.
This comment was marked as outdated.
isacikgoz
reviewed
Oct 19, 2023
nicksnyder
pushed a commit
to nicksnyder/go-i18n
that referenced
this pull request
Oct 23, 2023
Behavior has changed with #189. Before that, an empty default message returned nil and an error, now it returns "" without error. This has been detected by mattermost test suit in mattermost/mattermost#21327 which tries to switch all code base to go-i18n v2, see [related discussion](https://github.com/mattermost/mattermost/pull/21327/files#r1365634307)
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
… to cleanup empty plural forms Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
Signed-off-by: Nicolas Le Cam <[email protected]>
KuSh
force-pushed
the
GH-5267
branch
2 times, most recently
from
4b552f0
to
4d35b40
Compare
Signed-off-by: Nicolas Le Cam <[email protected]>
|
I've rebased the PR and I'm willing to maintain it if it's still valuable to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate to go-i18n 2.X to allow context-specific translations
Includes modifications to mmgotool (available in mattermost/mattermost-utilities#68 before the switch to monorepo)
Previously the tool seemed to ignore space only (i.e. " ") translations but that didn't seem right so I've changed the behavior. I've also updated the json format to use 2 space indentation to reflect current json format used in mattermost-server
Ticket Link
Fixes #5267
Fixes https://mattermost.atlassian.net/browse/MM-3943
Release Note