This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Printer: add tests #126
Merged
Printer: add tests #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isacikgoz
force-pushed
the
add-printer-tests
branch
from
d43223f
to
72d2c32
Compare
|
/update-branch |
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 60.73% 61.15% +0.41%
==========================================
Files 27 28 +1
Lines 2045 2085 +40
==========================================
+ Hits 1242 1275 +33
- Misses 763 768 +5
- Partials 40 42 +2
Continue to review full report at Codecov.
|
mgdelacroix
suggested changes
Mar 12, 2020
There was a problem hiding this comment.
I like the approach a lot, thanks for working on this @isacikgoz! A couple of minor comments noted
printer/printer_test.go
Outdated
| Print("test string") | ||
| Flush() | ||
|
|
||
| assert.Equal(t, "[\n \"test string\"\n]\n", string(mw.buffer)) |
There was a problem hiding this comment.
Can we add to the assertions a check for the state of printer.Lines?
printer/printer_test.go
Outdated
| Print("test string-1") | ||
| Print("test string-2") | ||
| Flush() | ||
| assert.Equal(t, "[\n \"test string-1\",\n \"test string-2\"\n]\n", string(mw.buffer)) |
There was a problem hiding this comment.
Same check for printer.Lines here
mgdelacroix
reviewed
Mar 12, 2020
Co-Authored-By: Miguel de la Cruz <[email protected]>
Co-Authored-By: Miguel de la Cruz <[email protected]>
mgdelacroix
reviewed
Mar 16, 2020
mgdelacroix
approved these changes
Mar 16, 2020
mgdelacroix
added
4: Reviews Complete
isacikgoz
force-pushed
the
add-printer-tests
branch
from
9ad4704
to
69f4b58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tests to printer package, a humble start for refactoring.
Ticket Link
No tickets yet.