Readme addition 1st draft & conditional guard cleaning #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edits to MD read me
Reduce repetition of code, change conditonal to a guard style. Only set the UInt32 inFlags to something other than zero if needed, but pass inFlags to the function call.
uchuugaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This literally pulls the original blog posts in, and should be cleaned up to reflect the code base as it is today. Though it would be nice if the original 2 code bases for each of the blog posts was available. For a learning tool it would help reflect the changes made over time to the design. With that in mind this might make a better Wiki page if the original code bases were added.
Also cleaning up redundancy in the conditional that determines what to do with if (discontinuous) and moving it to a more clear guard style.