Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you're compiling tests with webpack for Node (
target: node
), isomorphic-fetch will usenode-fetch
, which usesencoding
, which requiresiconv
dynamically, which causes warnings. This config will cause thoserequire
s to throw an error.It can seem weird to compile tests with webpack for Node, but it makes sense when you want to run your tests in the command-line or when you want to use certain Node testing tools or when you're testing React code which will be rendering on the server…
Of course, I won't be very sad if you don't feel like merging this, people with similar issues still will be able to find this PR.