Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad fmt.Fprintf at 'joy serve' #91

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

intelfike
Copy link
Contributor

Fixed bug.

'joy serve' couldn't use '%' in source code.

-		fmt.Fprintf(w, src)
+		fmt.Fprint(w, src)

Example of issue

joy.go

if n%3 == 0 {
	return "Fizz"
}

http://localhost:8080/bundle.js

if (n %! (MISSING)== 0) {
	return "Fizz";
};

@intelfike
Copy link
Contributor Author

It passed all test in local environment, but it couldn't pass SemaphoreCI's test.

command

go test -v ./...

How to pass SemaphoreCI's test? (I searching.)
Is it okay to create PullRequest again?

@matthewmueller
Copy link
Owner

Awesome – thanks!

I'll take a look at the semaphore stuff :-)

@matthewmueller matthewmueller merged commit cb3f14f into matthewmueller:master Mar 1, 2018
@intelfike
Copy link
Contributor Author

Oh, was it not important to pass the SemaphoreCI test at the Pull request?

Thanks for marge.
I can't wait stable version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants