Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add way to specify thumbnail format #574

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add way to specify thumbnail format #574

merged 2 commits into from
Jul 22, 2024

Conversation

autoantwort
Copy link
Contributor

Fixes #573

autoantwort added a commit to studi-bars/website that referenced this pull request Jun 26, 2024
@autoantwort
Use custom django-imagekit with extensions (use webp + generate srcset).
9628a39 
See the following PRs:
- matthewwithanm/django-imagekit#574
- matthewwithanm/django-imagekit#575
@vstoykov
Copy link
Collaborator

Thank you @autoantwort for your contribution. Can I ask you to add a simple test that is using the new format argument of the Thumbnail and verifying that it is actually being used?

@autoantwort
Copy link
Contributor Author

I also tried to add a test for the IMAGEKIT_DEFAULT_THUMBNAIL_FORMAT setting, but the setting is loaded while loading the module, which is only done once while the python process runs. I also tried importlib.reload, but with no success.

@vstoykov vstoykov merged commit c4ed0bb into matthewwithanm:develop Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Make it possible to specify the format for the thumbnail template tag
2 participants
@autoantwort @vstoykov