Check preconditions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkretz
force-pushed
the
check_preconditions
branch
from
df11a0b
to
baa25d5
Compare
For now only the existing `invoke_ub` were converted to use it. This is only enabled starting from GCC 10 as GCC 9 seems to fail preconditions at compile-time where it should not. ChangeLog: * README.md: Document VIR_CHECK_PRECONDITIONS. * testsuite/tests/mask_reductions.cc: Guard function calls with precondition behind constexpr-if. * vir/simd.h (detail::unreachable): New / moved from simd_execution.h. (detail::trap): New. (detail::invoke_ub): Moved up with behavior dependent on VIR_CHECK_PRECONDITIONS. (vir_simd_precondition): New macro. (simd, simd_mask): Replace invoke_ub with vir_simd_precondition. * vir/simd_execution.h (detail::unreachable): Moved to simd.h.
mattkretz
force-pushed
the
check_preconditions
branch
from
baa25d5
to
5e77196
Compare
ChangeLog: * .github/workflows/CI.yml: Add 10 and 12 to the GCC matrix.
mattkretz
force-pushed
the
check_preconditions
branch
from
70ff982
to
ab3bde0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.