Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade to Angular 15 #53

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat!: upgrade to Angular 15 #53

merged 4 commits into from
Jul 25, 2024

Conversation

aparzi
Copy link
Collaborator

@aparzi aparzi commented Jul 19, 2024

The library now supports angular 15.

@aparzi
update: upgrade to Angular 15
f644ec0 
The library now supports angular 15.
mattlewis92
mattlewis92 requested changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@mattlewis92 mattlewis92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Just had a few minor things. Also you said on your email that you wanted to upgrade to a higher angular version than v15, do you want to do that on this PR as well?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@mattlewis92 mattlewis92 changed the title update: upgrade to Angular 15 feat!: upgrade to Angular 15 Jul 19, 2024
@aparzi
Copy link
Collaborator Author

aparzi commented Jul 19, 2024

Looking good, thanks! Just had a few minor things. Also you said on your email that you wanted to upgrade to a higher angular version than v15, do you want to do that on this PR as well?

Hi @mattlewis92,
yes of course but I wanted to do more releases so as to support all versions, not make the direct jump from 14 to 18. Release all versions up to 18 and from 17 also have SSR management?

@aparzi
Copy link
Collaborator Author

aparzi commented Jul 20, 2024

Hi @mattlewis92,
I have update this PR. Can you check please?

@mattlewis92 mattlewis92 changed the base branch from main to next July 25, 2024 10:42
mattlewis92
mattlewis92 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm putting this in to a next branch for now and then we can release all the major version bumps in a single release

@mattlewis92 mattlewis92 merged commit e15af4a into mattlewis92:next Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlewis92 mattlewis92 mattlewis92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aparzi @mattlewis92