Build fixes for CGO #44
Open
+40
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the current workflow run here: https://github.com/darthShadow/go-ieproxy/actions/runs/3066692597 It's currently failing tests for darwin & windows when CGO is disabled:
|
Signed-off-by: Anagh Kumar Baranwal <[email protected]>
Signed-off-by: Anagh Kumar Baranwal <[email protected]>
darthShadow
force-pushed
the
build-fixes
branch
from
8ea7351
to
69928ad
Compare
This was referenced Oct 6, 2022
|
Hi, Is there any problem with this PR that I need to fix that would allow it to get merged? |
|
I think the Windows code doesn't use cgo (no |
|
Ah, I missed that bit. Do you want me to cherry-pick your commit or do you want to create a separate PR once/if this is merged? |
|
Any update on this? The windows support of an upstream project seems to depend on it 🥺 |
|
Sorry, could you please rebase master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to fix a few build errors due to cgo constraints and incorrect workflow for testing that.