sqlite3: don't copy string in bind() #1158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
=======================================
Coverage 47.16% 47.16%
=======================================
Files 12 12
Lines 1533 1533
=======================================
Hits 723 723
Misses 669 669
Partials 141 141 ☔ View full report in Codecov by Sentry. |
Change bind() to pass sqlite3_bind_text() a pointer to the strings data instead of converting it to a []byte just so a pointer to `&b[0]` can be passed to unsafe.Pointer. Basically, this saves a needless allocation. and passing a pointer to that. This is safe because sqlite3_bind_text does not keep a copy of the provided string.
charlievieth
force-pushed
the
cev/bind-string
branch
from
e4ab09f
to
6bd4c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change bind() to pass sqlite3_bind_text() a pointer to the strings data instead of converting it to a []byte just so a pointer to
&b[0]can be passed to unsafe.Pointer. Basically, this saves a needless allocation. and passing a pointer to that.This is safe because sqlite3_bind_text does not keep a copy of the provided string.