-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client.authenticate() should Base64 encode the data from the Authenticator #95
Comments
I agree, that seems reasonable! I'd be happy to review a PR. |
OK, I'll do that. |
kmkaplan
pushed a commit
to kmkaplan/rust-imap
that referenced
this issue
Nov 7, 2018
…uthenticator. Fixes issue mattnenterprise#95.
kmkaplan
pushed a commit
to kmkaplan/rust-imap
that referenced
this issue
Nov 7, 2018
…uthenticator. Fixes issue mattnenterprise#95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RFC 3501 6.2.2. AUTHENTICATE Command says that
So the Base64 encoding is really part of the IMAP protocol. The PLAIN SASL mecanism specification even does not show the encoding. That means that every
Authenticator::process
method has to do the Base64 encoding. It would be easier for everybody if that process was done insideClient.do_auth_handshake()
for everyAuthenticator
.If that sounds reasonnable I can provide a pull request.
The text was updated successfully, but these errors were encountered: