Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.authenticate() should Base64 encode the data from the Authenticator #95

Closed
kmkaplan opened this issue Nov 4, 2018 · 2 comments
Closed

Comments

@kmkaplan
Copy link

kmkaplan commented Nov 4, 2018

RFC 3501 6.2.2. AUTHENTICATE Command says that

The client response consists of a single line consisting of a BASE64 encoded string.

So the Base64 encoding is really part of the IMAP protocol. The PLAIN SASL mecanism specification even does not show the encoding. That means that every Authenticator::process method has to do the Base64 encoding. It would be easier for everybody if that process was done inside Client.do_auth_handshake() for every Authenticator.

If that sounds reasonnable I can provide a pull request.

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 4, 2018

I agree, that seems reasonable! I'd be happy to review a PR.

@kmkaplan
Copy link
Author

kmkaplan commented Nov 5, 2018

OK, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants