-
Notifications
You must be signed in to change notification settings - Fork 122
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4765413
commit ce9db42
Showing
6 changed files
with
175 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@total-typescript/ts-reset": minor | ||
--- | ||
|
||
Added support for widening in `Array.lastIndexOf`, `Array.indexOf`, `ReadonlyArray.lastIndexOf` and `ReadonlyArray.indexOf`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/// <reference path="utils.d.ts" /> | ||
|
||
interface ReadonlyArray<T> { | ||
lastIndexOf( | ||
searchElement: T | (TSReset.WidenLiteral<T> & {}), | ||
fromIndex?: number, | ||
): number; | ||
indexOf( | ||
searchElement: T | (TSReset.WidenLiteral<T> & {}), | ||
fromIndex?: number, | ||
): number; | ||
} | ||
|
||
interface Array<T> { | ||
lastIndexOf( | ||
searchElement: T | (TSReset.WidenLiteral<T> & {}), | ||
fromIndex?: number, | ||
): number; | ||
indexOf( | ||
searchElement: T | (TSReset.WidenLiteral<T> & {}), | ||
fromIndex?: number, | ||
): number; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
import { doNotExecute, Equal, Expect } from "./utils"; | ||
|
||
doNotExecute(async () => { | ||
const arr = ["1", "2", "3"] as const; | ||
|
||
// Look ma, no error! | ||
arr.indexOf("4"); | ||
|
||
// Look ma, proper errors! | ||
arr.indexOf( | ||
// @ts-expect-error | ||
2, | ||
); | ||
arr.indexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr = [1, 2, 3] as const; | ||
|
||
arr.indexOf(4); | ||
arr.indexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
arr.indexOf( | ||
// @ts-expect-error | ||
"str", | ||
); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr = [ | ||
{ a: 1 }, | ||
{ | ||
a: 2, | ||
}, | ||
{ | ||
a: 3, | ||
}, | ||
] as const; | ||
|
||
arr.indexOf( | ||
// @ts-expect-error | ||
4, | ||
); | ||
|
||
arr.indexOf({ a: 1 }); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr: Array<"1" | "2" | "3"> = ["1", "2", "3"]; | ||
|
||
arr.indexOf("4"); | ||
|
||
arr.indexOf( | ||
// @ts-expect-error | ||
2, | ||
); | ||
arr.indexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
}); | ||
|
||
// lastIndexOf | ||
|
||
doNotExecute(async () => { | ||
const arr = ["1", "2", "3"] as const; | ||
|
||
// Look ma, no error! | ||
arr.lastIndexOf("4"); | ||
|
||
// Look ma, proper errors! | ||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
2, | ||
); | ||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr = [1, 2, 3] as const; | ||
|
||
arr.lastIndexOf(4); | ||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
"str", | ||
); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr = [ | ||
{ a: 1 }, | ||
{ | ||
a: 2, | ||
}, | ||
{ | ||
a: 3, | ||
}, | ||
] as const; | ||
|
||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
4, | ||
); | ||
|
||
arr.lastIndexOf({ a: 1 }); | ||
}); | ||
|
||
doNotExecute(async () => { | ||
const arr: Array<"1" | "2" | "3"> = ["1", "2", "3"]; | ||
|
||
arr.lastIndexOf("4"); | ||
|
||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
2, | ||
); | ||
arr.lastIndexOf( | ||
// @ts-expect-error | ||
true, | ||
); | ||
}); |